Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade TokenContractClient to use the FA1.2 Token Specification #146

Merged
merged 4 commits into from
Jan 20, 2020

Conversation

keefertaylor
Copy link
Owner

@keefertaylor keefertaylor commented Jan 19, 2020

DEXter migrated to using FA1.2 contracts.

This PR wraps calls to FA1.2 token contracts in a TokenContractClient which provides the following operations:

  • Approve Allowance
  • Get Token Balance
  • Transfer Tokens

This PR is also a prerequisite to supporting the latest breaking changes in DEXter.

@codecov
Copy link

codecov bot commented Jan 19, 2020

Codecov Report

Merging #146 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
- Coverage   73.71%   73.67%   -0.04%     
==========================================
  Files          89       89              
  Lines        2678     2678              
==========================================
- Hits         1974     1973       -1     
- Misses        704      705       +1
Impacted Files Coverage Δ
TezosKit/Dexter/TokenContractClient.swift 93.02% <100%> (-2.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4b03a3...9018255. Read the comment docs.

@keefertaylor keefertaylor changed the title [WIP][Babylon] Dexter Functionality Upgrade TokenContractClient to use the FA1.2 Token Specification Jan 19, 2020
Copy link

@mchaver mchaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, looks like you have the important entry points covered.

Copy link
Collaborator

@simonmcl simonmcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good

@keefertaylor keefertaylor merged commit d63c378 into master Jan 20, 2020
@keefertaylor keefertaylor deleted the fix-token-contract branch January 20, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants