Add initial prototype Event Management files #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warning: failed to compile/link with the app
keegan-moore
commented
Mar 20, 2024
Comment on lines
+1
to
+3
| /* | ||
| * TODO: Fill in file header, if necessary. | ||
| */ |
There was a problem hiding this comment.
Does there need to be a file header for these files?
keegan-moore
commented
Mar 20, 2024
Comment on lines
+28
to
+36
| typedef struct | ||
| { | ||
| uint32_t ReturnValue; | ||
| } BPL_Status_t; | ||
|
|
||
| #define BPL_STATUS_SUCCESS (0u) | ||
| #define BPL_STATUS_ERROR_GENERAL (1u) | ||
| #define BPL_STATUS_ERROR_INPUT_INVALID (2u) | ||
| #define BPL_STATUS_ERROR_PROXY_INIT (3u) |
There was a problem hiding this comment.
I assume these should be moved to somewhere else (if we decide to keep the struct impl of the return types, as discussed).
keegan-moore
commented
Mar 20, 2024
| BPL_EVM_ProxyCallbacks.Initialize_Impl = ProxyCallbacks.Initialize_Impl; | ||
| BPL_EVM_ProxyCallbacks.SendEvent_Impl = ProxyCallbacks.SendEvent_Impl; | ||
|
|
||
| /* TODO: immediately want to call the proxy init, or wait for a directive to do so? */ |
There was a problem hiding this comment.
Need to address this TODO
There was a problem hiding this comment.
Consider removing the Initialize_Impl function pointer entirely. Have the BPNode call CFE_EVS_Register (or any other initialization) directly.
now that things are working
keegan-moore
changed the title
using utassert_generate_stubs.pl
This reverts commit bd88db4.
This was referenced Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
This PR add prototype implementations for the BPLib's Event Management (EVM) design (part of the Core Infrastructure).
This design intends to abstract the cFS EVS API calls from the BP App, using a new EVM API the BPLib.
A related PR exists for BP app, here: keegan-moore/bp#1 .
Testing performed
make native.distclean2.
make ENABLE_TESTS=false native.installcd build-native-9.4.0/exe/cpu1./core-cpu1Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.
BPL_EVM_Initializeinstead ofCFE_EVS_RegisterBPL_EVM_SendEventSystem(s) tested on
Additional context
N/A
Third party code
N/A
Contributor Info - All information REQUIRED for consideration of pull request
Keegan Moore, NASA/GSFC Code 582 (Flight Software Systems)