Jm update docs for net standard #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd fix places where examples used the old namespace structure.
baumatron
approved these changes
Nov 14, 2017
| Now, launch Visual Studio and open `Keen.sln`. Build the solution, discover unit tests, and run them. Or, if using the .NET Core SDK tools, build and make sure tests pass: | ||
|
|
||
| ```ssh | ||
| $ dotnet build |
There was a problem hiding this comment.
Does this actually work these days from the root of the project?
There was a problem hiding this comment.
Yeah it will, but I should probably mention error MSB3644 or explicitly passing -f netstandard2.0 on platforms where you don't/can't have the right SDK/targeting pack for netfx4.5.
There was a problem hiding this comment.
Fun fact: running dotnet test from the root of the solution works too, which I didn't realize.
- Call out an error/warning that occurs building the 4.5 target on non-Windows platforms. - I noticed the NewSemVer script is trying to clean the `Debug` config instead of `Release`. - There were some lingering references to the old `netfx` config in the .csproj files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.