Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser Integration tests #3016

Merged
merged 1 commit into from May 29, 2019

Conversation

3 participants
@varjolintu
Copy link
Member

commented Apr 16, 2019

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have read the CONTRIBUTING document. [REQUIRED]
  • My code follows the code style of this project. [REQUIRED]
  • All new and existing tests passed. [REQUIRED]
  • I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]

@varjolintu varjolintu added this to the v2.4.2 milestone Apr 16, 2019

@varjolintu varjolintu requested review from droidmonkey and louib Apr 16, 2019

@varjolintu varjolintu force-pushed the varjolintu:browser_tests branch 2 times, most recently from 2284ae7 to 8aca6e1 Apr 16, 2019

@varjolintu

This comment has been minimized.

Copy link
Member Author

commented Apr 16, 2019

The ugly JSON code is because older Qt versions don't support [] operators with QJsonValue.

@varjolintu varjolintu force-pushed the varjolintu:browser_tests branch from 8aca6e1 to a623084 Apr 16, 2019

Show resolved Hide resolved tests/TestBrowser.cpp Outdated
Show resolved Hide resolved tests/TestBrowser.cpp Outdated
Show resolved Hide resolved tests/TestBrowser.cpp Outdated

@varjolintu varjolintu force-pushed the varjolintu:browser_tests branch from a623084 to ec25f89 Apr 21, 2019

@varjolintu varjolintu force-pushed the varjolintu:browser_tests branch from ec25f89 to 32f75ef May 26, 2019

@varjolintu

This comment has been minimized.

Copy link
Member Author

commented May 26, 2019

Rebased. Now all the checks are passed.

Show resolved Hide resolved src/browser/BrowserAction.h Outdated

@varjolintu varjolintu force-pushed the varjolintu:browser_tests branch from 32f75ef to cd7689d May 29, 2019

Changes were made

@droidmonkey droidmonkey merged commit 5341a82 into keepassxreboot:release/2.4.2 May 29, 2019

4 checks passed

CodeFactor No issues found.
Details
MacOS (KeepassXC) TeamCity build finished
Details
Ubuntu Linux (KeepassXC) TeamCity build finished
Details
Windows 10 (KeepassXC) TeamCity build finished
Details

@varjolintu varjolintu deleted the varjolintu:browser_tests branch May 29, 2019

droidmonkey added a commit that referenced this pull request May 31, 2019

Release 2.4.2
- Improve resilience against memory attacks - overwrite memory before free [#3020]
- Prevent infinite save loop when location is unavailable [#3026]
- Attempt to fix quitting application when shutdown or logout issued [#3199]
- Support merging database custom data [#3002]
- Fix opening URL's with non-http schemes [#3153]
- Fix data loss due to not reading all database attachments if duplicates exist [#3180]
- Fix entry context menu disabling when using keyboard navigation [#3199]
- Fix behaviors when canceling an entry edit [#3199]
- Fix processing of tray icon click and doubleclick [#3112]
- Update group in preview widget when focused [#3199]
- Prefer DuckDuckGo service over direct icon download (increases resolution) [#2996]
- Remove apply button in application settings [#3019]
- Use winqtdeploy on Windows to correct deployment issues [#3025]
- Don't mark entry edit as modified when attribute selection changes [#3041]
- Use console code page CP_UTF8 on Windows if supported [#3050]
- Snap: Fix locking database with session lock [#3046]
- Snap: Fix theming across Linux distributions [#3057]
- Snap: Use SNAP_USER_COMMON and SNAP_USER_DATA directories [#3131]
- KeeShare: Automatically enable WITH_XC_KEESHARE_SECURE if quazip is found [#3088]
- macOS: Fix toolbar text when in dark mode [#2998]
- macOS: Lock database on switching user [#3097]
- macOS: Fix global Auto-Type when the database is locked [#3138]
- Browser: Close popups when database is locked [#3093]
- Browser: Add tests [#3016]
- Browser: Don't create default group if custom group is enabled [#3127]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.