sail:config新增接口实现检测并完善测试用例

Author: keepchen

sail/config.go

@@ -43,6 +43,8 @@ type ConfigProvider interface {
 	ViaNacos(endpoints, namespaceID, groupName, dataID string, clientCfg ...constant.ClientConfig) Parser
 }
 
+var _ ConfigProvider = &configImpl{}
+
 // ViaFile 通过文件操作配置
 func (ci *configImpl) ViaFile(filename string) Parser {
 	content, err := utils.File().GetContents(filename)
@@ -142,12 +144,19 @@ func (ci *configImpl) ViaNacos(endpoints, namespaceID, groupName, dataID string,
 	if err != nil && ci.panicWhileErr {
 		panic(err)
 	}
-	content, err := client.GetConfig(vo.ConfigParam{
-		DataId: dataID,
-		Group:  groupName,
-	})
-	if err != nil && ci.panicWhileErr {
-		panic(err)
+	if client == nil && ci.panicWhileErr {
+		panic("client is nil")
+	}
+	var content []byte
+	if client != nil {
+		data, err := client.GetConfig(vo.ConfigParam{
+			DataId: dataID,
+			Group:  groupName,
+		})
+		content = []byte(data)
+		if err != nil && ci.panicWhileErr {
+			panic(err)
+		}
 	}
 
 	//当监听函数被设置时，需要执行监听
@@ -163,7 +172,7 @@ func (ci *configImpl) ViaNacos(endpoints, namespaceID, groupName, dataID string,
 		})
 	}
 
-	return &parserImpl{content: []byte(content)}
+	return &parserImpl{content: content}
 }
 
 // parserImpl 解析器实现
@@ -177,6 +186,9 @@ type Parser interface {
 	Parse(fn func(content []byte, viaWatch bool))
 }
 
+var _ Parser = &parserImpl{}
+
+// Parse 解析处理函数
 func (pi *parserImpl) Parse(fn func(content []byte, viaWatch bool)) {
 	if fn != nil {
 		fn(pi.content, false)

sail/config_test.go

@@ -85,3 +85,19 @@ func TestConfigViaEtcd(t *testing.T) {
 		Config(false, watcherFunc).ViaEtcd(etcdConf, testConfigFilename).Parse(watcherFunc)
 	})
 }
+
+func TestConfigViaNacos(t *testing.T) {
+	t.Run("ConfigViaNacos-Panic", func(t *testing.T) {
+		assert.Panics(t, func() {
+			Config(true, nil).ViaNacos("127.0.0.1:8848", "", "", "this-file-not-exist.json")
+		})
+	})
+	t.Run("ConfigViaNacos-None-Panic", func(t *testing.T) {
+		Config(false, nil).ViaNacos("127.0.0.1:8848", "", "", "this-file-not-exist.json")
+	})
+	t.Run("ConfigViaNacos-Truly", func(t *testing.T) {
+		Config(false, watcherFunc).ViaNacos("127.0.0.1:8848", "", "", testConfigFilename)
+
+		Config(false, watcherFunc).ViaNacos("127.0.0.1:8848", "", "", testConfigFilename).Parse(watcherFunc)
+	})
+}