Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multitenant elastic #1326

Merged
merged 20 commits into from
Jul 7, 2024
Merged

feat: multitenant elastic #1326

merged 20 commits into from
Jul 7, 2024

Conversation

shahargl
Copy link
Member

@shahargl shahargl commented Jul 4, 2024

No description provided.

Copy link

vercel bot commented Jul 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Jul 7, 2024 1:41pm

Copy link

codecov bot commented Jul 7, 2024

Codecov Report

Attention: Patch coverage is 30.12048% with 58 lines in your changes missing coverage. Please review.

Project coverage is 37.68%. Comparing base (58d30ad) to head (13dc284).
Report is 15 commits behind head on main.

Files Patch % Lines
keep/api/core/tenant_configuration.py 31.57% 26 Missing ⚠️
keep/api/core/elastic.py 29.16% 17 Missing ⚠️
keep/api/core/db.py 13.33% 13 Missing ⚠️
tests/conftest.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1326       +/-   ##
===========================================
- Coverage   63.12%   37.68%   -25.45%     
===========================================
  Files         103       26       -77     
  Lines        8058     2216     -5842     
===========================================
- Hits         5087      835     -4252     
+ Misses       2971     1381     -1590     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

talboren
talboren previously approved these changes Jul 7, 2024
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahargl shahargl merged commit 40809ae into main Jul 7, 2024
9 checks passed
@shahargl shahargl deleted the feature/elastic-multitenant branch July 7, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants