Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: converting workflow results datetime objects (#1255) #1382

Closed
wants to merge 1 commit into from

Conversation

ArtArtem
Copy link
Contributor

Describe the bug
When the result of a workflow execution might include datetime object, we're unable to save it in to the database because of a serialization problem.

Solution:
So now, according to mock testing data:
e.g.
mock_action1 = Mock(name="action1")
mock_action1.name = "action1"
mock_action 1.provider.results = {"result": "value1"}

results dict's fields will be iterated and datetime objects will be converted to be properly saved in DB

image

Needs to be double checked with relevant workflowexecution data

Copy link

vercel bot commented Jul 15, 2024

@ArtArtem is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Jul 17, 2024 7:52am

@talboren
Copy link
Member

Hey @ArtArtem
Thank you for this contribution! Unfortunately, this doesn't seem to be the right way to solve this issue. Please see: #1236 for more details.

@talboren talboren closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants