Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rulesengine to index alert in elastic #1577

Merged
merged 8 commits into from
Aug 11, 2024
Merged

fix: rulesengine to index alert in elastic #1577

merged 8 commits into from
Aug 11, 2024

Conversation

talboren
Copy link
Member

@talboren talboren commented Aug 11, 2024

close #1576

Copy link

vercel bot commented Aug 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Aug 11, 2024 9:11am

Copy link

codecov bot commented Aug 11, 2024

Codecov Report

Attention: Patch coverage is 23.52941% with 13 lines in your changes missing coverage. Please review.

Project coverage is 39.82%. Comparing base (c0be6a5) to head (bd17bd0).
Report is 36 commits behind head on main.

Files Patch % Lines
keep/api/utils/cel_utils.py 21.42% 11 Missing ⚠️
keep/api/core/elastic.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1577       +/-   ##
===========================================
- Coverage   68.38%   39.82%   -28.57%     
===========================================
  Files         112       28       -84     
  Lines        9288     2576     -6712     
===========================================
- Hits         6352     1026     -5326     
+ Misses       2936     1550     -1386     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Matvey-Kuk
Matvey-Kuk previously approved these changes Aug 11, 2024
@talboren talboren enabled auto-merge (squash) August 11, 2024 09:26
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@talboren talboren merged commit b4a283d into main Aug 11, 2024
10 checks passed
@talboren talboren deleted the 1540-fix-build branch August 11, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Group alerts not indexed in Elastic
3 participants