Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: slightly different UX for provider tiles without hiding content on hover #1736

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

Kiryous
Copy link
Contributor

@Kiryous Kiryous commented Aug 26, 2024

Closes #1738

📑 Description

Hiding parts of UI on hover is not a great UX, the proposal is to remove buttons that appear on hover in favor of simply click on card itself and a gear icon for modify action.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information


Watch Loom with comparison

Copy link

vercel bot commented Aug 26, 2024

@Kiryous is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@talboren
Copy link
Member

@Kiryous

  1. Seems like tests are failing, can you check that please?
  2. Can you please open a respective issue for that and mention it in the description of the PR: "close #ISSUE_NUMBER"

Thanks!

@Kiryous Kiryous changed the title feature: slightly different UX for provider tiles without hiding content on hover feat: slightly different UX for provider tiles without hiding content on hover Aug 27, 2024
@Kiryous
Copy link
Contributor Author

Kiryous commented Aug 27, 2024

@talboren hey! updated tests accordingly to the new dom structure and created an issue.

Copy link

vercel bot commented Aug 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Aug 27, 2024 0:25am

@talboren talboren enabled auto-merge (squash) August 27, 2024 12:28
@talboren talboren self-requested a review August 27, 2024 12:28
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@talboren talboren merged commit f6ca7d1 into keephq:main Aug 27, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🔨 Enhancement]: Robust providers tiles UX
2 participants