Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Basic prometheus exporter & documentation fix #1747

Merged
merged 27 commits into from
Sep 1, 2024

Conversation

Matvey-Kuk
Copy link
Contributor

@Matvey-Kuk Matvey-Kuk commented Aug 28, 2024

close #1746, also started fixing documentation and it exploded, sorry 💥:

  • We had a lot of documentation pages (some pretty important) not listed in the mint.json, so they were not accessible via navigation.
  • Probably that's why we had a few documentation pages duplicated (for example, 2 different dev quickstarts)
  • Also fixed 27 broken links.
  • Added a test to validate documentation's menu has links to all files.
  • Added a test to validate documentation's links.
  • Added a test to validate all providers are listed in docs.

Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Sep 1, 2024 11:27am

@Matvey-Kuk Matvey-Kuk changed the title Basic prometheus exporter feat: Basic prometheus exporter Aug 28, 2024
Copy link
Contributor

@VladimirFilonov VladimirFilonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Matvey-Kuk Matvey-Kuk changed the title feat: Basic prometheus exporter feat: Basic prometheus exporter & documentation fix Aug 28, 2024
docs/mint.json Outdated Show resolved Hide resolved
Copy link
Contributor

@VladimirFilonov VladimirFilonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

Matvey-Kuk and others added 2 commits September 1, 2024 13:12
Co-authored-by: Vladimir Filonov <vladimir@filonov.dev>
Signed-off-by: Matvey Kukuy <Matvey-Kuk@users.noreply.github.com>
@Matvey-Kuk Matvey-Kuk merged commit 4d0c891 into main Sep 1, 2024
9 of 11 checks passed
@Matvey-Kuk Matvey-Kuk deleted the Matvey-Kuk/prom-metrics branch September 1, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[➕ Feature]: Export app's metrics to the Prometheus
2 participants