Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): topology route mistakenly removed #1790

Merged
merged 2 commits into from
Sep 2, 2024
Merged

fix(api): topology route mistakenly removed #1790

merged 2 commits into from
Sep 2, 2024

Conversation

shahargl
Copy link
Member

@shahargl shahargl commented Sep 2, 2024

close #1789

Copy link

vercel bot commented Sep 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 8:29am

@talboren talboren changed the title fix: topology fix(api): topology route mistakenly removed Sep 2, 2024
@talboren talboren self-requested a review September 2, 2024 08:16
talboren
talboren previously approved these changes Sep 2, 2024
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@talboren talboren merged commit 56f4b6c into main Sep 2, 2024
12 of 13 checks passed
@talboren talboren deleted the bugfix/topology branch September 2, 2024 08:32
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.70%. Comparing base (6d5c759) to head (7430e43).
Report is 34 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1790       +/-   ##
===========================================
+ Coverage   30.68%   66.70%   +36.01%     
===========================================
  Files          54      140       +86     
  Lines        5028    10968     +5940     
===========================================
+ Hits         1543     7316     +5773     
- Misses       3485     3652      +167     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: topology route mistakenly removed
2 participants