Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): cloud-sql-python-connector #1868

Merged
merged 3 commits into from
Sep 8, 2024
Merged

Conversation

shahargl
Copy link
Member

@shahargl shahargl commented Sep 8, 2024

close #1869

Copy link

vercel bot commented Sep 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Sep 8, 2024 1:16pm

@talboren talboren self-requested a review September 8, 2024 12:40
@talboren talboren changed the title feat: update cloud sql chore(deps): cloud-sql-python-connector Sep 8, 2024
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 66.92%. Comparing base (ac7eae1) to head (6dfbbd9).
Report is 59 commits behind head on main.

Files with missing lines Patch % Lines
keep/api/api.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1868      +/-   ##
==========================================
- Coverage   68.36%   66.92%   -1.44%     
==========================================
  Files         120      144      +24     
  Lines        9839    11433    +1594     
==========================================
+ Hits         6726     7652     +926     
- Misses       3113     3781     +668     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahargl shahargl merged commit 7b441f1 into main Sep 8, 2024
15 checks passed
@shahargl shahargl deleted the feature/update-cloud-sql branch September 8, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Huge amount of errors on cloud run regarding SQL
2 participants