Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: don't allow update/edit provisioned resources #1916

Merged
merged 14 commits into from
Sep 15, 2024

Conversation

shahargl
Copy link
Member

close #1915

Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Sep 14, 2024 3:34pm

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 21.10092% with 86 lines in your changes missing coverage. Please review.

Project coverage is 67.89%. Comparing base (6d5c759) to head (2702d78).
Report is 90 commits behind head on main.

Files with missing lines Patch % Lines
keep/workflowmanager/workflowstore.py 11.26% 63 Missing ⚠️
keep/api/core/db.py 29.62% 19 Missing ⚠️
keep/api/api.py 33.33% 2 Missing ⚠️
keep/api/routes/workflows.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1916       +/-   ##
===========================================
+ Coverage   30.68%   67.89%   +37.20%     
===========================================
  Files          54      142       +88     
  Lines        5028    11587     +6559     
===========================================
+ Hits         1543     7867     +6324     
- Misses       3485     3720      +235     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahargl shahargl merged commit 7e9d06d into main Sep 15, 2024
11 checks passed
@shahargl shahargl deleted the feature/provisioned-resources branch September 15, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[➕ Feature]: do not allow edit/update provisioned resources
2 participants