Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(performance): better performance for celpy #2005

Merged
merged 6 commits into from
Sep 25, 2024

Conversation

shahargl
Copy link
Member

@shahargl shahargl commented Sep 25, 2024

close #2006

main improvements:

  1. disable internal logging __repr__ of celpy library (see Performance of evaluation cloud-custodian/cel-python#68)
  2. "caches" the activation part (which takes 30-40% of the time) between presets (redundant)
  3. remove schema validation from list[AlertDto] to just list (reduce 300ms per execution)

Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2024 3:49pm

@talboren talboren changed the title feat: better performance for celpy fix: better performance for celpy Sep 25, 2024
@shahargl shahargl changed the title fix: better performance for celpy feat(performance): better performance for celpy Sep 25, 2024
@shahargl shahargl merged commit fb72f73 into main Sep 25, 2024
11 checks passed
@shahargl shahargl deleted the feature/better-celpy-perf branch September 25, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ 🏎️ Perfomance]: Improve performance of search alerts and preset/alert endpoints
2 participants