Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provider): add logger option to console provider #2043

Merged
merged 5 commits into from
Sep 30, 2024

Conversation

shahargl
Copy link
Member

@shahargl shahargl commented Sep 30, 2024

close #2044

Copy link

vercel bot commented Sep 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 10:59am

talboren
talboren previously approved these changes Sep 30, 2024
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Matvey-Kuk
Matvey-Kuk previously approved these changes Sep 30, 2024
@talboren talboren dismissed stale reviews from Matvey-Kuk and themself via ad77274 September 30, 2024 10:38
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.63%. Comparing base (ab4b44a) to head (ad77274).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2043      +/-   ##
==========================================
- Coverage   69.95%   69.63%   -0.32%     
==========================================
  Files         150      152       +2     
  Lines       13297    13414     +117     
==========================================
+ Hits         9302     9341      +39     
- Misses       3995     4073      +78     
Flag Coverage Δ
69.63% <ø> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shahargl shahargl merged commit 29718c1 into main Sep 30, 2024
13 checks passed
@shahargl shahargl deleted the feature/console-to-log branch September 30, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[➕ Feature]: Allow to use logger in console provider
3 participants