Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get_service_application_ids_dict: handle json_arrayagg for mysql… #2051

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

Kiryous
Copy link
Contributor

@Kiryous Kiryous commented Sep 30, 2024

… and other dialects

Closes #2046

📑 Description

Mysql return json string instead of real array, e.g. (<service_id>, "[<app_id>, <app_id>]"), this PR adds parsing to feed array of UUIDs into DTO.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

Copy link

vercel bot commented Sep 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Sep 30, 2024 2:54pm

talboren
talboren previously approved these changes Sep 30, 2024
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kiryous Kiryous merged commit 4e6dff0 into main Sep 30, 2024
10 checks passed
@Kiryous Kiryous deleted the fix/2046-topology-applications-func-agg branch September 30, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ 🐛Bug ] /topology crashes with 500 on mysql after creating application
3 participants