Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some issues on groups #770

Merged
merged 1 commit into from
Jan 31, 2024
Merged

fix: some issues on groups #770

merged 1 commit into from
Jan 31, 2024

Conversation

shahargl
Copy link
Member

No description provided.

Copy link

vercel bot commented Jan 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
keep ⬜️ Ignored (Inspect) Jan 31, 2024 2:37pm

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (217eb47) 55.60% compared to head (9898124) 55.56%.

Files Patch % Lines
keep/rulesengine/rulesengine.py 0.00% 5 Missing ⚠️
keep/api/core/db.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #770      +/-   ##
==========================================
- Coverage   55.60%   55.56%   -0.05%     
==========================================
  Files          80       80              
  Lines        4947     4951       +4     
==========================================
  Hits         2751     2751              
- Misses       2196     2200       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shahargl shahargl merged commit 5de6fbe into main Jan 31, 2024
7 of 9 checks passed
@shahargl shahargl deleted the fix/groups branch January 31, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant