Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic auth support and error check for http(s) handlers #54

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

drunkbatya
Copy link

@drunkbatya drunkbatya commented Sep 25, 2023

  • Add basic auth support and error check for GelfHttpHandler and GelfHttpsHandler

@keeprocking
Copy link
Owner

Hi, I'll look into it this week.

Thank you.

pygelf/handlers.py Outdated Show resolved Hide resolved
@drunkbatya drunkbatya changed the title Add basic auth support, add http code check Add basic auth support Dec 11, 2023
@drunkbatya drunkbatya changed the title Add basic auth support Add basic auth support and error check for http(s) handlers Dec 11, 2023
@drunkbatya
Copy link
Author

drunkbatya commented Dec 11, 2023

I added an error checks again, through try/catch construction, and also assert for status code to catch unauthorized and other https errors. I replaced throwing exceptions with native logging's self.handleError(record) . This also may close issue 52.

@drunkbatya
Copy link
Author

@keeprocking does I need to make any changes before merge may occur?

@keeprocking
Copy link
Owner

Hi, sorry for the delay - I'm currently undergoing medical treatment and will get back to this as soon as possible. No exact time frame, sorry.

@chilledornaments
Copy link
Contributor

@drunkbatya would you mind adding tests for this functionality? I believe you need to add new inputs here and more params to tests/test*.py (for example)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants