Refactoring DnsCache and how to resolve Service Instance #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keepsimple1
force-pushed
the
simple-cache-2
branch
from
9224a2f
to
0c1db35
Compare
Simplify the logic of resolving an instance: always resolve from the cache. For any incoming updates, we update the cache first, then try to resolve.
keepsimple1
force-pushed
the
simple-cache-2
branch
from
0c1db35
to
6fd6991
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the logic of resolving an instance: always resolve from the cache. For any incoming updates, we update the cache first, then try to resolve according to the cache.
We're still not doing all the things for the cache updates as mentioned in RFCs, but I think with the changes, the future enhancements will be easier.
instances_foundand the related state. As they are essentially another kind of cache but it is error-prone to keep them up-to-date and consistent withDnsCache.