Fix panic due to range out of bounds in txt record parsing #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keepsimple1
reviewed
Dec 23, 2023
src/service_info.rs
Outdated
| let kv_bytes = &txt[offset..offset + length]; | ||
| let offset_end = offset + length; | ||
| if offset_end > txt.len() { | ||
| break; // Would be out of range, skipping this property. |
There was a problem hiding this comment.
Make sense! Could you also add a log of offset_end and txt.len() when this happens? I would say error!() level. And if error!() doesn't work for you, debug!() level is also fine.
Can you also add a unit test in this file inside mod tests for this negative case? A simple test input would be fine.
ps. A nitty: it is not only "skipping this property", it's actually "skipping the rest of TXT" .
There was a problem hiding this comment.
Gotcha, I've give given it a go!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the following panic in my crash reporting earlier:
I'm not entirely sure if this would be the correct solution, but I've made an attempt.