Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor testcases fix #95

Closed
wants to merge 1 commit into from

Conversation

zoranbosnjak
Copy link

  • some build warnings fixed
  • fix build problem under 'nix' environment

- some build warnings fixed
- fix build problem under 'nix' environment
@zoranbosnjak
Copy link
Author

@myroslambda @keera-studios-admin
Is this project maintained?
It is marked "broken" in the nix packages. I belive that this pull request would fixed the nix-build problem. Please consider merging it to the upstream.

@myroslambda
Copy link
Contributor

myroslambda commented May 25, 2021

It is, but the fix is incomplete.

These haddock tests are all over the place, so more than just these two would have to change. We need to create two separate issues (one for the warnings and one for the haddock command invocation) and apply the fixes independently.

I do not understand why calling haddock directly without providing some context or a package DB will work. How does haddock know where to look for existing packages?

@myroslambda
Copy link
Contributor

I have created both issues (#96, #97). I will close this PR and we will address those independently. I will point to this PR from both. We can continue the discussion there.

Thanks for the PR and for bringing my attention to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants