Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manifest V3 fixes #62

Merged
merged 4 commits into from
Aug 4, 2024
Merged

Manifest V3 fixes #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f111a6c
Update background in manifest
HarlemSquirrel Aug 2, 2024
6b3c788
Add back background.scripts to manifest
HarlemSquirrel Aug 2, 2024
64766d7
Fix ReferenceError: window is not defined
HarlemSquirrel Aug 2, 2024
df8b0ac
Update firefox build command
HarlemSquirrel Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,8 @@
"128": "icons/icon128.png"
},
"background": {
"scripts": [
"js/background.js"
]
"scripts": ["js/background.js"],
"service_worker": "js/background.js"
},
"permissions": [
"activeTab",
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"scripts": {
"start": "npm run eslint && npm run build-chrome && npm run build-firefox && npm run build-edge && npm run build-safari",
"build-chrome": "cross-env KW_BROWSER=chrome webpack --mode=production",
"build-firefox": "cross-env KW_BROWSER=firefox webpack --mode=production",
"build-firefox": "cross-env KW_BROWSER=firefox webpack --mode=production && npx web-ext build -o -s dist/firefox",
"build-edge": "cross-env KW_BROWSER=edge webpack --mode=production",
"build-safari": "cross-env KW_BROWSER=safari webpack --mode=production",
"watch-chrome": "cross-env KW_BROWSER=chrome webpack --mode=development --watch",
Expand Down
2 changes: 1 addition & 1 deletion src/background/backend.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ class Backend extends TypedEmitter<BackendEvents> {

private request(request: KeeWebConnectRequest): Promise<KeeWebConnectResponse> {
return new Promise((resolve, reject) => {
const timeout = window.setTimeout(() => {
const timeout = self.setTimeout(() => {
this._currentRequest = undefined;
const errStr = chrome.i18n.getMessage('errorRequestTimeout');
reject(new Error(errStr));
Expand Down
Loading