Model Type Selection with GPT-4 #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll consider adding it when I get an access to GPT-4 (I haven't gotten it yet). |
| { | ||
| case ModelType.gpt_4: | ||
| return "gpt-4"; | ||
| default: |
There was a problem hiding this comment.
Should be a ModelType.gpt_3_5_turbo case before default. More practical for future versions of GPT. I'd also argue the default case should throw an error or at least log that it defaults to 3.5 because the given enum value could not be found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just added in a change so that a model type can be selected, and you can pick between GPT-3.5-Turbo, and GPT-4.
A warning is displayed if you select GPT-4 reminding you that you need approved API access for GPT-4
Thanks!