-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add onset beat detection. #17
Comments
This might disappoint you, but there is no plan for adding beat detection to the plugin. Actually, I'm avoiding spending more time on this topic (beat onset detection) because I failed several times to implement it and wasted too much time. My conclusion is that there is no such thing as a perfect beat detection algorithm. |
Oh? Then how does a CDJ do it so nicely? Haha. I know it may be somewhat challenging. Can call it “onset beat detection for standard electronic bass drums used in most electronic dance music”. Doing it for EVERY acoustic genre does seem as though it could be somewhat challenging though.
… On Jul 20, 2019, at 5:55 PM, Keijiro Takahashi ***@***.***> wrote:
Closed #17 <#17>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#17?email_source=notifications&email_token=ACJ7JDXXOB2WZP7TIGZEEALQALOK3A5CNFSM4IFN5CC2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOSTOIQUQ#event-2497480786>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACJ7JDUWLIQJFIB5K3WUNFTQALOK3ANCNFSM4IFN5CCQ>.
|
Any chance you could share your (failed) attempts? As judging from your other code they could very well be better than what's out there. As some apps just need it at least as a fall-back for non-savvy users who want to be able to have something synced with any audio source, or microphone imput, and can't use a midi beatclock or Ableton Link. I'm currently giving this (imho not great) implementation a go: |
Nice start! アゲポヨ! Add onset beat detection though. Basically a bass drum is usually a very fast transition from a high frequency to a low frequency. Thus, use that to detect the bass drum.
Thanks in advance for adding that. Will make it easier to track the main rhythm. That will make Para Para easier for any Para Para Gyaru Girls I put in My apps.
PS: Maybe moving back to Japan soon. By the way, that new MIDI file to anim player looks great! Also, when have a chance and want a lot of love from the mobile XR community, get a TAA plugin functioning in single pass stereo on android. (mobile XR) Spent all day yesterday testing to find a way to get bloom working on single pass stereo in mobile XR and the ONLY solution I found was a plugin called "BEAUTIFY". Basically Unity's post processing team has seemingly been flailing around some because Keijiro hasn't been actively involved.
The text was updated successfully, but these errors were encountered: