Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecated replacements section removed #190

Merged
merged 2 commits into from
Jan 23, 2023

Conversation

anushkabishnoi
Copy link
Contributor

Signed-off-by: Anushka Bishnoi anushkabishnoi9@gmail.com

Signed-off-by: Anushka Bishnoi <anushkabishnoi9@gmail.com>
@anushkabishnoi anushkabishnoi requested a review from a team as a code owner January 20, 2023 09:33
.goreleaser.yml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Merging #190 (de12b9e) into master (516e325) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #190   +/-   ##
=======================================
  Coverage   49.60%   49.60%           
=======================================
  Files          14       14           
  Lines        1923     1923           
=======================================
  Hits          954      954           
  Misses        840      840           
  Partials      129      129           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Anushka Bishnoi <anushkabishnoi9@gmail.com>
@kevdowney
Copy link
Collaborator

@anushkabishnoi DCO failed b/c your git username is decapacitator.

Expected "decapacitator [anushkabishnoi9@gmail.com](mailto:anushkabishnoi9@gmail.com)", but got "Anushka Bishnoi [anushkabishnoi9@gmail.com](mailto:anushkabishnoi9@gmail.com)"

https://github.com/keikoproj/addon-manager/pull/190/checks?check_run_id=10797311702

Your signature must match your user.name, for future you can set this correct by running:

git config user.name "Anushka Bishnoi" --global

For now I can probably override this check. ;)

@kevdowney kevdowney merged commit 7f042c8 into keikoproj:master Jan 23, 2023
@anushkabishnoi
Copy link
Contributor Author

@anushkabishnoi DCO failed b/c your git username is decapacitator.

Expected "decapacitator [anushkabishnoi9@gmail.com](mailto:anushkabishnoi9@gmail.com)", but got "Anushka Bishnoi [anushkabishnoi9@gmail.com](mailto:anushkabishnoi9@gmail.com)"

https://github.com/keikoproj/addon-manager/pull/190/checks?check_run_id=10797311702

Your signature must match your user.name, for future you can set this correct by running:

git config user.name "Anushka Bishnoi" --global

For now I can probably override this check. ;)

I figured that out and changed my user name on github desktop, but probably after creating this pr :(. Anyway thanks for letting me contribute here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants