Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log node drain command output as info log #48

Merged

Conversation

viveksyngh
Copy link
Contributor

Sometimes need to look at the output of drain command to figure out which pod on a node is causing
drain command failure/timeout.

Signed-off-by: Vivek Singh svivekkumar@vmware.com

Sometimes need to look at the output of drain command to figure out which pod on a node is causing
drain command failure/timeout.

Signed-off-by: Vivek Singh <svivekkumar@vmware.com>
@viveksyngh viveksyngh requested a review from a team as a code owner April 2, 2021 07:35
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #48 (8df4b75) into master (a6dff72) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   56.77%   56.81%   +0.04%     
==========================================
  Files           5        5              
  Lines         923      924       +1     
==========================================
+ Hits          524      525       +1     
  Misses        336      336              
  Partials       63       63              
Impacted Files Coverage Δ
pkg/reaper/nodereaper/helpers.go 60.88% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6dff72...8df4b75. Read the comment docs.

Copy link
Collaborator

@eytan-avisror eytan-avisror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eytan-avisror eytan-avisror merged commit 1720c62 into keikoproj:master Apr 2, 2021
shaoxt pushed a commit to shaoxt/governor that referenced this pull request Dec 21, 2021
Sometimes need to look at the output of drain command to figure out which pod on a node is causing
drain command failure/timeout.

Signed-off-by: Vivek Singh <svivekkumar@vmware.com>
Signed-off-by: shaoxt <shaoxt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants