Controller v2: remove cleaning up ruObject as BDD already does. #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sbadla1 <sahil_badla@intuit.com>
…manager into controller-v2 Signed-off-by: sbadla1 <sahil_badla@intuit.com>
…manager into controller-v2 Signed-off-by: sbadla1 <sahil_badla@intuit.com>
Signed-off-by: sbadla1 <sahil_badla@intuit.com>
Signed-off-by: sbadla1 <sahil_badla@intuit.com>
Issue 2122
Signed-off-by: sbadla1 <sahil_badla@intuit.com>
Signed-off-by: sbadla1 <sahil_badla@intuit.com>
Signed-off-by: sbadla1 <sahil_badla@intuit.com>
Signed-off-by: sbadla1 <sahil_badla@intuit.com>
Signed-off-by: sbadla1 <sahil_badla@intuit.com>
Signed-off-by: sbadla1 <sahil_badla@intuit.com>
Signed-off-by: sbadla1 <sahil_badla@intuit.com>
Signed-off-by: sbadla1 <sahil_badla@intuit.com>
Signed-off-by: sbadla1 <sahil_badla@intuit.com>
Signed-off-by: sbadla1 <sahil_badla@intuit.com>
…-manager into controller-v2 Signed-off-by: sbadla1 <sahil_badla@intuit.com>
Signed-off-by: sbadla1 <sahil_badla@intuit.com>
…-manager into controller-v2 Signed-off-by: sbadla1 <sahil_badla@intuit.com>
…manager into controller-v2 Signed-off-by: sbadla1 <sahil_badla@intuit.com>
…-manager into controller-v2 Signed-off-by: sbadla1 <sahil_badla@intuit.com>
…manager into controller-v2 Signed-off-by: sbadla1 <sahil_badla@intuit.com>
Signed-off-by: sbadla1 <sahil_badla@intuit.com>
Signed-off-by: sbadla1 <sahil_badla@intuit.com>
…manager into controller-v2 Signed-off-by: sbadla1 <sahil_badla@intuit.com>
Signed-off-by: sbadla1 <sahil_badla@intuit.com>
shreyas-badiger
changed the title
shreyas-badiger
added a commit
that referenced
this pull request
Aug 26, 2021
* Controller v2 (#289) * #2286: removed version from metric namespace Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <sahil_badla@intuit.com> * update bdd for testing Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: change cron Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: change cron Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: change cron Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: change cron Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: bdd changes for v2 Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: bdd changes for v2 Signed-off-by: sbadla1 <sahil_badla@intuit.com> Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * Controller v2 (#290) * #2286: removed version from metric namespace Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <sahil_badla@intuit.com> * update bdd for testing Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: change cron Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: change cron Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: change cron Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: change cron Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: bdd changes for v2 Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: bdd changes for v2 Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: bdd changes for v2 Signed-off-by: sbadla1 <sahil_badla@intuit.com> Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * Controller v2 (#291) * #2286: removed version from metric namespace Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <sahil_badla@intuit.com> * update bdd for testing Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: change cron Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: change cron Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: change cron Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: change cron Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: bdd changes for v2 Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: bdd changes for v2 Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: bdd changes for v2 Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: bdd changes for v2 Signed-off-by: sbadla1 <sahil_badla@intuit.com> Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * Controller v2 (#292) * #2286: removed version from metric namespace Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <sahil_badla@intuit.com> * update bdd for testing Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: change cron Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: change cron Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: change cron Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: change cron Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: bdd changes for v2 Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: bdd changes for v2 Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: bdd changes for v2 Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: bdd changes for v2 Signed-off-by: sbadla1 <sahil_badla@intuit.com> * #2122: added sh for dockerfile Signed-off-by: sbadla1 <sahil_badla@intuit.com> Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * check for ASG's launch template version instead latest. (#293) Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * controller v2: Fix ci job (#295) * fix CI job * fix Makefile Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * Release v1.0.1 (#294) Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * replace launchTemplate latest string with version number (#296) Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * Release v1.0.2 (#297) Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * Add ignoreDrainFailure and DrainTimeout as controller arguements Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * Sequential AWS API call for setting instances to StandBy Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * Set Instances to StandBy in batches Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * Set Instances to StandBy in batches Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * Set Instances to StandBy in batches Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * Set Instances to StandBy in batches Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * fix: fix panic when using MixedInstancesPolicy (#298) Signed-off-by: Jonah Back <jonah@jonahback.com> Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * fix vet errors Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * remove log messagE Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * change the logic Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * fix vet error Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * fix lint errors Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * add comment Signed-off-by: sbadiger <shreyas_badiger@intuit.com> Co-authored-by: Sahil Badla <sahil_badla@intuit.com> Co-authored-by: Jonah Back <jonah@jonahback.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.