-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autofix for similar letters #57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
A couple of remarks that it would be great if you could fix but otherwise looking good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keyword only arguments
It seems that there's something wrong with |
Huh yeah, looks like a new version was causing some issues. Fixed on master! Could you rebase and also squash the commits together? |
It failed for python 3.5 |
ah looks like the mypy type checker is failing in the__main__ module, makes sense considering the functions don't have the same signature anymore. mypy is only being run on 3.5 so that's why it's only failing that build |
Typing that bit explicitly solves it
|
Oh that kind of annotation is only 3.6+ hmm, I don't think it's time to drop 3.5 already. I need to think about this one |
This syntax is not supported on python 3.5 so this old syntax needs to be used until support is dropped for 3.5
fix #54