Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorting scripts fails when switching from npm-run-all to npm-run-all2 #308

Closed
viceice opened this issue Jan 29, 2024 · 2 comments · Fixed by #309
Closed

sorting scripts fails when switching from npm-run-all to npm-run-all2 #308

viceice opened this issue Jan 29, 2024 · 2 comments · Fixed by #309

Comments

@viceice
Copy link

viceice commented Jan 29, 2024

Renovate is now suggesting to replace the npm-run-all with npm-run-all2 which is good, but on some repos prettier starts failing.
Any idea?

diff --git a/package.json b/package.json
index 9090468..58a787e 100644
--- a/package.json
+++ b/package.json
@@ -7,8 +7,8 @@
   "author": "Michael Kriese <michael.kriese@visualon.de>",
   "type": "module",
   "scripts": {
-    "lint": "run-s prettier",
     "postinstall": "husky install",
+    "lint": "run-s prettier",
     "prettier": "prettier \"{**/*,*}.*\" --check --ignore-unknown",
     "prettier:fix": "prettier \"{**/*,*}.*\" --write --ignore-unknown"
   },
@viceice
Copy link
Author

viceice commented Jan 29, 2024

Seeing it on yarn v3 and pnpm v8, so seems unrelated to package manager

@kachkaev
Copy link
Contributor

Also seeing this in a PR created by Renovate bot. This should be fixed by #309.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants