Added proc_net_tcp parser #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Will take a closer look in the next few days. |
kellyjonbrazil
requested changes
Jun 19, 2023
Comment on lines
+36
to
+45
| "tm->when": string, | ||
| "retrnsmt": string, | ||
| "uid": string, | ||
| "timeout": string, | ||
| "inode": string, | ||
| "sock_ref_count": string, | ||
| "sock_mem_loc": string, | ||
| "retransmit_timeout": string, | ||
| "soft_clock_tick": string, | ||
| "(ack.quick<<1)|ack.pingpong": string, |
There was a problem hiding this comment.
Could we rename the tm->when and (ack.quick<<1)|ack.pingpong fields. I try to keep field-names to only alphanumerics and underscores.
There was a problem hiding this comment.
Also, should any of these values be converted to ints or floats?
|
I'll go ahead and merge this into dev and clean up a couple things. Thank you for the contribution! |
kellyjonbrazil
added a commit
that referenced
this pull request
Jul 30, 2023
* version bump * fix regex for crlf line endings * Completed Ip_route parser (#429) * tests * Merge pull request #398 from kellyjonbrazil/dev Dev v1.23.2 * Merge pull request #398 from kellyjonbrazil/dev Dev v1.23.2 --------- Co-authored-by: Kelly Brazil <kellyjonbrazil@gmail.com> Co-authored-by: Jjack3032 <julian.jackson@parsons.us> * formatting * doc update * use splitlines * formatting * formatting * Parser for `find` linux command (#434) * Added find parser and tests for Centos 7.7 and Ubuntu 18.04 * Added a test file, changed logic, and included a case for permission denied returned by find. * Added a few more lines to the tests * Changed logic for setting values to null and updated test cases. * doc update * doc update * Added proc_net_tcp parser (#421) Co-authored-by: Kelly Brazil <kellyjonbrazil@gmail.com> * clean up net_tcp parser * add resolve.conf test files * doc update * add resolve.conf parser * doc update * add sortlist functionality * add resolve.conf parser tests * doc update --------- Co-authored-by: Julian5555 <58196809+Julian5555@users.noreply.github.com> Co-authored-by: Jjack3032 <julian.jackson@parsons.us> Co-authored-by: solomonleang <124934439+solomonleang@users.noreply.github.com> Co-authored-by: AlvinSolomon <41175627+AlvinSolomon@users.noreply.github.com>
sumezulike
pushed a commit
to sumezulike/jc
that referenced
this pull request
Sep 21, 2023
* version bump * fix regex for crlf line endings * Completed Ip_route parser (kellyjonbrazil#429) * tests * Merge pull request kellyjonbrazil#398 from kellyjonbrazil/dev Dev v1.23.2 * Merge pull request kellyjonbrazil#398 from kellyjonbrazil/dev Dev v1.23.2 --------- Co-authored-by: Kelly Brazil <kellyjonbrazil@gmail.com> Co-authored-by: Jjack3032 <julian.jackson@parsons.us> * formatting * doc update * use splitlines * formatting * formatting * Parser for `find` linux command (kellyjonbrazil#434) * Added find parser and tests for Centos 7.7 and Ubuntu 18.04 * Added a test file, changed logic, and included a case for permission denied returned by find. * Added a few more lines to the tests * Changed logic for setting values to null and updated test cases. * doc update * doc update * Added proc_net_tcp parser (kellyjonbrazil#421) Co-authored-by: Kelly Brazil <kellyjonbrazil@gmail.com> * clean up net_tcp parser * add resolve.conf test files * doc update * add resolve.conf parser * doc update * add sortlist functionality * add resolve.conf parser tests * doc update --------- Co-authored-by: Julian5555 <58196809+Julian5555@users.noreply.github.com> Co-authored-by: Jjack3032 <julian.jackson@parsons.us> Co-authored-by: solomonleang <124934439+solomonleang@users.noreply.github.com> Co-authored-by: AlvinSolomon <41175627+AlvinSolomon@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #420