Template tests #137
Merged
Template tests #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -66,7 +66,6 @@ Wrapper for [strings.Split](http://golang.org/pkg/strings/#Split). Splits the in | |||
| {{ $url := split (getv "/deis/service") ":" }} | |||
| host: {{index $url 0}} | |||
| port: {{index $url 1}} | |||
| {{end}} | |||
| ``` | |||
There was a problem hiding this comment.
Looks like we still need the {{end}} tag
There was a problem hiding this comment.
{{end}} isn't necessary here. See the test for split. If {{end}} is present, the template won't parse.
tomdee
added a commit
to tomdee/confd
that referenced
this pull request
Jul 31, 2018
ci and cd push all arches; ability to exclude specific
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for all template functions in a framework that should make it easier to write more in the future.
Added missing template functions to templates.md.