Retry when rate-limit ceiling reached #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the contribution. Could you fix the test that the change of the error message broke? |
|
Fixed the unit test + include which status triggered the failure (400/429) |
staabm
suggested changes
May 10, 2017
| @@ -200,7 +200,7 @@ public function failsWithInvalidDirectoryResponseButCorrectErrorResponse() { | |||
| * @test | |||
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ACME imposes a 20 request/second rate-limit on new-reg, new-authz, and new-cert requests. This PR amends POST to include a 1 second sleep/retry on 429 responses to work around the rate-limit threshold on larger certificate requests.