feat!: add keyboard shortcuts to dropdown components #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djcouto
force-pushed
the
dc/add-keyboard-shortcuts
branch
from
1772d6b
to
16e09fa
Compare
GoncaloCamaz
approved these changes
Sep 18, 2023
packages/react-ui-components/src/stories/Components/SingleSelectDropdown.stories.tsx
Outdated
Show resolved
Hide resolved
djcouto
force-pushed
the
dc/add-keyboard-shortcuts
branch
4 times, most recently
from
48c5605
to
d67b652
Compare
packages/ui-components/src/components/multi-select-dropdown/multi-select-dropdown.tsx
Outdated
Show resolved
Hide resolved
packages/ui-components/src/components/single-select-dropdown/single-select-dropdown.types.ts
Show resolved
Hide resolved
pedrorebelocosta
approved these changes
Sep 21, 2023
djcouto
force-pushed
the
dc/add-keyboard-shortcuts
branch
2 times, most recently
from
ea308ee
to
1cb4ba1
Compare
miguelpinto98
approved these changes
Sep 22, 2023
packages/react-ui-components/src/stories/Components/helpers/dropdown.helper.ts
Outdated
Show resolved
Hide resolved
packages/ui-components/src/components/select-multi-options/select-multi-options.tsx
Outdated
Show resolved
Hide resolved
…ngle-select-dropdown` component
BREAKING CHANGES:
- `ISingleSelectDropdownOptions` was renamed to `ISelectSingleOptions`
- `ISingleSelectDropdownOption` was renamed to `ISelectSingleOption`
djcouto
force-pushed
the
dc/add-keyboard-shortcuts
branch
from
1cb4ba1
to
5cec58f
Compare
feat(dropdowns): add items virtualisation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES:
-
ISingleSelectDropdownOptionswas renamed toISelectSingleOptions-
ISingleSelectDropdownOptionwas renamed toISelectSingleOption