Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick up Transitional Type Aliases #566

Merged
merged 1 commit into from
May 16, 2020
Merged

Conversation

toddsundsted
Copy link
Contributor

This change explicitly requires dependent code so that transitional types aliases (and deprecation warnings) are included. Paves the way for the release of 0.35.0.

See: crystal-lang/crystal#8886 (specifically the type aliases).

Description of the Change

Simply explicitly requires dependent code. When not present, building against the currently nightly crystal build results in errors like the following (including when running the specs):

...
...
In src/kemal/helpers/helpers.cr:135:8
 135 | File.open(file_path) do |file|
            ^---
Error: instantiating 'File.class#open(String)'

In src/kemal/helpers/helpers.cr:143:7
 143 | Gzip::Writer.open(env.response) do |deflate|
       ^-----------
Error: undefined constant Gzip::Writer

Benefits

This change does not affect existing functionality, but avoids problems when building against the current nightly crystal build, and presumably 0.35.0 when it's released.

This change explicitly requires dependent code so that transitional
types aliases (and deprecation warnings) are included. Paves the way
for the release of 0.35.0.

See: crystal-lang/crystal#8886
toddsundsted added a commit to toddsundsted/ktistec that referenced this pull request Apr 27, 2020
I'm currently building off nightly, which introduced some breakage in
packages not tested against nightly.

See: kemalcr/kemal#566
@sdogruyol
Copy link
Member

Thanks @toddsundsted 🙏

@sdogruyol sdogruyol merged commit 70684a2 into kemalcr:master May 16, 2020
@toddsundsted toddsundsted deleted the track-8886 branch May 17, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants