Remove Kilt #618
Merged
Remove Kilt #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
approved these changes
Sep 8, 2021
mamantoha
approved these changes
Sep 8, 2021
|
I'd also like to thank @henrikac for the initial effort 🙏 |
toddsundsted
added a commit
to toddsundsted/ktistec
that referenced
this pull request
Apr 16, 2022
See: kemalcr/kemal#618 Kilt was removed from Kemal. Ktistec depends on Kilt to render Slang templates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR removes Kilt and all the reference to it. Fixes #617
Benefits
Kemal will now only rely on ECR which is already built-into the Crystal standard library
Possible Drawbacks
The users must include and use
Kiltthemsevels