Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Info enums to support new OpenCL versions and extensions. #13

Closed
kenba opened this issue Oct 9, 2021 · 1 comment
Closed

Remove Info enums to support new OpenCL versions and extensions. #13

kenba opened this issue Oct 9, 2021 · 1 comment
Assignees
@kenba
Labels
enhancement New feature or request

Comments

@kenba
Copy link
Owner

kenba commented Oct 9, 2021

The *_info functions take a *Info enum to get the relevant type of data for the given value.
Therefore the *_info functions can only handle known values; new OpenCL versions and extensions often provide new values to call: clGetPlatformInfo, clGetDeviceInfo, clGetProgramInfo, etc.

If the *_info functions just took a cl_platform_info, cl_device_info, cl_program_info, etc parameter instead, then the functions could return a Result<Vec, cl_int> for unknown but valid OpenCL values.

This would be a major change to the interface, but it would simplify the software and make it more resilient to OpenCL changes.
@kenba kenba mentioned this issue Oct 9, 2021
Closed
kenba added a commit that referenced this issue Oct 10, 2021
@kenba
Remove Info enums for issue #13.
7e702ae
kenba added a commit that referenced this issue Oct 15, 2021
@kenba
Remove extension "Info" types for issue #13
a3e5bf9
@kenba kenba self-assigned this Oct 15, 2021
@kenba kenba added the enhancement New feature or request label Oct 15, 2021
@kenba
Copy link
Owner Author

kenba commented Oct 15, 2021

Incorporated in version 0.6.0.

@kenba kenba closed this as completed Oct 15, 2021
@kenba kenba mentioned this issue Apr 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kenba kenba

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kenba