Params #34
Merged
Params #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parse_post_body now just parses the posst body not the query string.
|
seeing intermittent failure from the test @katjaeinsfeld added, but i think it is a ramification of the define_app business:
i think i have a quick fix... |
|
yeah, sorry - not related. 👍 |
kenichi
added a commit
that referenced
this pull request
Jan 22, 2015
|
Not related but yeah I've seen this failure. It's consistent for a given On Thu, Jan 22, 2015 at 10:35 AM, kenichi nakamura <notifications@github.com
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yeah I sit around doing things like this instead of doing tests for the code I've written. But a method called "parse_post_body" that also parsed the query_string was asking for a bit of refactor so it would stop confusing me.