Skip to content

Conversation

@kenjis
Copy link
Owner

kenjis commented Apr 22, 2015

Thank you for your PR.

Your code did not work (Parse error and Fatal error), so I fixed: f013d2e
Is it okay?

@jorelcb
Copy link
Author

jorelcb commented Apr 22, 2015

Perfect!. Thank You for that fix.

@jorelcb jorelcb closed this Apr 23, 2015
@jorelcb jorelcb reopened this Apr 23, 2015
@jorelcb
Copy link
Author

jorelcb commented Apr 30, 2015

getAutoloaderConfig function fixed, please check!

@kenjis
Copy link
Owner

kenjis commented May 2, 2015

Thank you. But I already fixed and merged your PR.

I updated my benchmarks:
https://github.com/kenjis/php-framework-benchmark/tree/optimize#hello-world-benchmark

But I don't see the effect of this optimization. In fact the rps decreased a little by chance.
When I benchmarked for the first time, the number increased a little.

@kenjis kenjis closed this Jun 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants