Relax dependent thor
version to fix CI
#46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @kenn,
sunzi
's CI failed withruby-head (3.2.0dev)
.https://github.com/kenn/sunzi/pull/45/checks?check_run_id=5319265537
That's because
sunzi
depends on olderthor
(v0.20.x),thor
at that version usesopen-uri
internally, butopen-uri
was removed since Ruby 3.x release.https://github.com/ruby/ruby/blob/v3_0_0/NEWS.md#compatibility-issues
thor
v1.x usesURI.open
so that it is compatible with Ruby 3.x.rails/thor#677
This pull request removes dependent
thor
version from the gemspec file, so thatsunzi
will use newerthor
and it works fine with Ruby 3.x.Before this patch:
After this patch (
bundle install && bundle update
):