Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix actions #6

Merged
merged 1 commit into from
Jun 18, 2015
Merged

Fix actions #6

merged 1 commit into from
Jun 18, 2015

Conversation

knownasilya
Copy link
Contributor

Fixes #5

@kennethkalmer
Copy link
Owner

@knownasilya thanks so much!

Two things quickly:

  • Could you clean up the slideAction = this.get('slide') on line 40 as well please?
  • Why the Ember.run() wrappers? Just curious and looking to learn on this one.

@kennethkalmer
Copy link
Owner

Before we get this merged, lets have a chat through the API in #5.

@knownasilya
Copy link
Contributor Author

Ember.run prevents unwanted behavior and missed event triggers, since Ember manages when things happen. Since these are events in an external library, the callbacks are not handled automatically by the Ember runloop.

That slideAction check is necessary to make sure to not throw errors in the console if the user hasn't set a slide='mySlideAction'.

@kennethkalmer kennethkalmer merged commit c328359 into kennethkalmer:master Jun 18, 2015
@kennethkalmer
Copy link
Owner

@knownasilya thanks for your contribution! Just published 0.4.1 as a fix.

@kennethkalmer kennethkalmer mentioned this pull request Jun 18, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knownasilya @kennethkalmer