New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: TonedScale wasn't working for tonics in octave 0 #14

Merged

kennethreitz merged 1 commit into kennethreitz:master from diegodukao:reitz

Sep 19, 2018

Contributor

diegodukao commented Sep 18, 2018

Trying to use TonedScale with a tonic in octave 0 was rasing ValueError.
This was working correctly before 629ce15

>>> a0 = TonedScale(tonic="A0")
>>> a0.scales

File "/home/diego/Projects/_libraries_src/pytheory/pytheory/tones.py", line 92, in _index
    return self.system.tones.index(self.name)
ValueError: tuple.index(x): x not in tuple

This PR fix it.


          bugfix: TonedScale wasn't working for tonic in octave 0

8ae7533

kennethreitz merged commit 18ac589 into kennethreitz:master

diegodukao deleted the reitz branch

September 19, 2018 14:58

heliomeiralins mentioned this pull request

Merged PRs are not on master. #19

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet