Add robustness to automatic decoder instantiation #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poneill
reviewed
Jun 16, 2021
poneill
reviewed
Jun 17, 2021
poneill
reviewed
Jun 17, 2021
poneill
reviewed
Jun 17, 2021
added 2 commits
June 19, 2021 17:30
|
any update on this? |
|
Yeah sorry, was moving states, but most of the code it already done, will update and hopefully land code tomorrow |
poneill
approved these changes
Jul 10, 2021
|
Is this still in development ? I found some of the same issues/errors fixed on this branch and i was waiting for this merge to look in deep |
|
my bad sorry, I got busy with other projects. Will get back to this very soon |
|
@jedzill4 @sarim-zafar sorry for the delay, the new code should now be up on pypi as v0.1.1. Please let us know if there are still issues. |
|
Thanks for the work! it works smoothly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff adds better parsing for alphabets as well as sanity checks + logging around potential issues during instantiation