Skip to content

Commit

Permalink
fix(TS): make container optional in RenderOptions (#253)
Browse files Browse the repository at this point in the history
**What**: TS: make container optional in RenderOptions

<!-- Why are these changes necessary? -->

**Why**: Particularly useful if you're making a custom render with custom options. If you extend the type and call your custom render without the container but with the other options then you get a false error.

<!-- How were these changes implemented? -->

**How**: `?`

<!-- Have you done all of these things?  -->

**Checklist**:

<!-- add "N/A" to the end of each line that's irrelevant to your changes -->

<!-- to check an item, place an "x" in the box like so: "- [x] Documentation" -->

- [ ] Documentation N/A
- [ ] Tests N/A
- [x] Ready to be merged
      <!-- In your opinion, is this ready to be merged as soon as it's reviewed? -->
- [ ] Added myself to contributors table N/A
      <!-- this is optional, see the contributing guidelines for instructions -->

<!-- feel free to add additional comments -->
  • Loading branch information
Kent C. Dodds committed Dec 20, 2018
1 parent f099d2f commit 4763ffb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion typings/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export interface RenderResult extends GetsAndQueries {
}

export interface RenderOptions {
container: HTMLElement
container?: HTMLElement
baseElement?: HTMLElement
hydrate?: boolean
}
Expand Down

0 comments on commit 4763ffb

Please sign in to comment.