Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow flag to bypass required IP check when creating device #12

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

aaronfuj
Copy link
Contributor

Adds a client-side flag within the creation of a device about whether or not to allow creation of devices without an IP address. To keep backwards compatibility, this is false but default, meaning that if someone tries to create a device but does not provide an IP address, the code will return an error (like it works prior to this PR).

Copy link
Contributor

@jabersmith jabersmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aaronfuj aaronfuj merged commit 19fca60 into master Aug 25, 2021
@aaronfuj aaronfuj deleted the af_create_device_without_ip branch August 25, 2021 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants