Fixed a race condition when shutting down Agg #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Agg is stopped, the
done
channel is written to, which signalsits
aggregate()
goroutine loop to exit. This is fine, except thisdone
channel is also returned to the caller via
Done()
. The intended flowis for
aggregate()
to catch thedone
channel write, and then wrapup, close the output channel that the caller is reading from, and write
again to the
done
channel for the caller. However, if the callercatches the first message before Agg does, then Agg never shuts down.
The fix here is to have two channels - one to signal that we're shutting
down (
quitting
), and one to signal that we've shut down (done
). Thefirst one is private, just for communication with its own goroutines.
The second is exposed to the caller. We're also now closing channels,
rather than writing to them, for good measure, since we're only using
them as quit channels.