Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweaking device create #7

Merged
merged 2 commits into from
Nov 25, 2019
Merged

Tweaking device create #7

merged 2 commits into from
Nov 25, 2019

Conversation

i3149
Copy link
Contributor

@i3149 i3149 commented Nov 20, 2019

@i3149 i3149 requested a review from sersim November 20, 2019 17:07
sersim
sersim approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@sersim sersim left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit.
Don't know if there are other situations in which we need to create devices with different subtypes

@sersim sersim merged commit 018570a into master Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sersim sersim sersim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@i3149 @sersim