Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Python packaging? #264

Closed
danghai opened this issue Apr 29, 2018 · 11 comments
Closed

Consider Python packaging? #264

danghai opened this issue Apr 29, 2018 · 11 comments

Comments

@danghai
Copy link
Collaborator

danghai commented Apr 29, 2018

No description provided.

@keon
Copy link
Owner

keon commented Apr 29, 2018

I started this repo with the educational purpose, but I think this could be a potential direction for development.
in order to do this, we need to

  • work on standardizing filenames and api
  • make docs for using api
  • package and publish in pypi

I found algorithms is already in pypi, but it is not maintained (https://github.com/nryoung/algorithms).
It is actually pointing to our repo. Maybe I could reach out and talk.

@danghai
Copy link
Collaborator Author

danghai commented Apr 30, 2018

@keon Awesome!, lets package them locally first. I create the PR for this: #268. But it has some issues. And you can reach out and talk about pypi with them. After local package works fine. We will push everything on pypi.

@danghai
Copy link
Collaborator Author

danghai commented May 1, 2018

It works for python packaging locally. I merge them in repo. Lets check README, let me know if you have any errors

@keon
Copy link
Owner

keon commented May 2, 2018

shouldn't the api be something like:

from algorithms.sort import merge_sort?

we do not want to overwrite python's native api

@danghai
Copy link
Collaborator Author

danghai commented May 2, 2018

@keon Yeah it is my mistake. But in order to do it, we need to group all source file under algorithms folder. What do you think?

@danghai
Copy link
Collaborator Author

danghai commented May 3, 2018

@goswami-rahul do you know how to handle it :) ?

@goswami-rahul
Copy link
Collaborator

@danghai I have not yet worked on any packaging related stuff in Python, and I am not very familiar with these setup.py, etc. files yet.
I will be helpful in this, once I get acquainted with these stuff. I hope its not too difficult to understand, if you could explain briefly what exactly are we going to do. :)
And yeah, I agree with you in containg all these modules under an algorithms folder.

@keon
Copy link
Owner

keon commented May 4, 2018

I'll get back to this in a week. I am pressed by an urgent issue right now 🔥

@keon
Copy link
Owner

keon commented Jun 4, 2018

I have some good news coming. stay tuned!

@keon keon mentioned this issue Jun 6, 2018
1 task
@keon
Copy link
Owner

keon commented Jun 6, 2018

Thanks to Nic(@nryoung), we are live in PyPI!
He also agreed to join us as one of the maintainers, so please welcome!
now you can install the package with simple command pip install algorithms.

Please note that this is still a preliminary release.
We have some more improvements to make before releasing version 1.0.0.

  • docs
  • consistent api

@keon keon closed this as completed in #320 Jun 6, 2018
@goswami-rahul
Copy link
Collaborator

Cheers! :)

@keon keon reopened this Jun 6, 2018
@keon keon closed this as completed Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants