Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CONFIG_UPLOAD_MESSAGE to avoid confusion #115

Merged
merged 1 commit into from
Jun 15, 2018

Conversation

JustinGOSSES
Copy link
Contributor

Very small change to wording of the CONFIG_UPLOAD_MESSAGE to make it clear that, to upload a previous map, you have to upload a single JSON that contains both the old data and all config.

Trying to upload separate JSONs, which seems like a possible way forward with the old message, in fact doesn't work and results in a map that tries to load forever.

Changed the CONFIG_UPLOAD_MESSAGE to make it clear that, to upload a previous map, you have to upload a "single" JSON that contains "both" the old data and all config. 

Trying to upload separate JSONs of previously used config and previously used data, which seems like a possible way forward with the old message, in fact doesn't work and results in a map that tries to load forever. 

This small change makes it clear that users should look for the option that exports both the config and data together in a single JSON. This is a radio button on the bottom of the export window that changes from the default state of separate exports to an 'everything' export.
@heshan0131 heshan0131 merged commit 694eede into keplergl:master Jun 15, 2018
@JustinGOSSES JustinGOSSES deleted the changeFileUploadMessage branch June 16, 2018 05:48
bjungs pushed a commit to imec-int/kepler.gl that referenced this pull request Nov 14, 2022
…y-detail-page

[BUBR-901] Asset inventory detail page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants