Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix icon layer instructions #131

Merged
merged 3 commits into from
Jun 26, 2018
Merged

[Bug] Fix icon layer instructions #131

merged 3 commits into from
Jun 26, 2018

Conversation

heshan0131
Copy link
Contributor

  • Move layer info modal to layer class
  • Add a button to layer panel to open layer info modal if defined

icon-layer-how-to

Copy link
Contributor

@javidhsueh javidhsueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -38,6 +38,7 @@ export const StyledLayerConfigGroupLabel = styled.div`
export const StyledLayerConfigGroup = styled.div`
padding-left: 18px;
margin-bottom: 18px;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra line

@heshan0131 heshan0131 merged commit ba4bbd7 into master Jun 26, 2018
@macrigiuseppe macrigiuseppe deleted the fix-icon-instruction branch October 21, 2018 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants