refactor coxpcall dependency #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
like ringer.lua & xavante.lua
all is already done in wsapi.common see https://github.com/keplerproject/wsapi/blob/master/src/wsapi/common.lua#L21-L25 `coxpcall` (like `rings`) are not longer a direct dependencies of `wsapi-fcgi` & `wsapi-xavante`. So, the `rockspec` could be updated like this: ```diff wsapi: -dependencies = { "luafilesystem >= 1.6.2" } +dependencies = { "luafilesystem >= 1.6.2", "rings >= 1.3.0", "coxpcall >= 1.14" } wsapi-fcgi: -dependencies = { "wsapi >= 1.6.1", "rings >= 1.3.0", "coxpcall >= 1.14" } +dependencies = { "wsapi >= 1.6.x" } wsapi-xavante: -dependencies = { "wsapi >= 1.6.1", "rings >= 1.3.0", "coxpcall >= 1.14", "xavante >= 2.3.0" } +dependencies = { "wsapi >= 1.6.x", "xavante >= 2.3.0" } ```
use same logic as in copas see https://github.com/keplerproject/copas/blob/master/src/copas.lua#L28-L30
|
Merged, thank you! |
buildroot-auto-update
pushed a commit
to buildroot/buildroot
that referenced
this pull request
Apr 7, 2019
since version 1.7, coxpcall is only required with Lua 5.1 see, keplerproject/wsapi#41 Signed-off-by: Francois Perrad <francois.perrad@gadz.org> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
buildroot-auto-update
pushed a commit
to buildroot/buildroot
that referenced
this pull request
Apr 14, 2019
since version 1.7, coxpcall is only required with Lua 5.1 see, keplerproject/wsapi#41 Signed-off-by: Francois Perrad <francois.perrad@gadz.org> Signed-off-by: Peter Korsgaard <peter@korsgaard.com> (cherry picked from commit b7b8a7f) Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note1: follow PR #30
note2: tested with orbit and Lua 5.1